Skip to content

temporarily patch custom defined llm clients on api #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

miguelg719
Copy link
Collaborator

why

what changed

test plan

Copy link

changeset-bot bot commented Jul 9, 2025

🦋 Changeset detected

Latest commit: cb4f80b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@miguelg719 miguelg719 marked this pull request as ready for review July 15, 2025 19:26
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR implements a temporary patch in lib/index.ts to handle custom LLM clients in API mode. The change adds a warning log message and automatically disables API mode when a custom LLM client is provided to prevent potential compatibility issues.

The change is relatively simple but important for system stability - it adds a safeguard to prevent custom LLM clients from being used in API mode, which could cause unexpected behavior. This is marked as a temporary solution, suggesting a more permanent fix will be developed later.

PR Description Notes:

  • The PR description is empty and should be filled out with the required why/what/test plan sections

Confidence score: 4/5

  1. Safe to merge - straightforward defensive programming change that prevents potential issues
  2. High confidence due to the simplicity of the change and clear failure prevention
  3. Files needing attention:
    • lib/index.ts - should verify that disabling API mode doesn't have unintended side effects

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant